Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove RAILS_MASTER_KEY from ci #470

Draft
wants to merge 11 commits into
base: staging
Choose a base branch
from

Conversation

guidojw
Copy link
Member

@guidojw guidojw commented Nov 21, 2024

Checklist

  • merged database migrations into 1 database migration
  • tested database migrations from origin/staging (git checkout staging ; git pull ; bundle exec rails db:reset ; git checkout BRANCH ; bundle exec rails db:migrate)

Summary

Shortly summarize the changes in this pull request. Does it concern changes in the UI, add some screenshots. Are there related issues solved? Please, mention them (with 'fixes #xyz', see https://github.com/blog/1506-closing-issues-via-pull-requests), so they can be resolved automatically when merging this pull request.

Other information

If there is some other relavent and imporant information for this pull request, mention it here. For example, related pull requests (also in amber-api) or newly introduced conventions, packages or other dependencies.

@guidojw guidojw marked this pull request as draft November 21, 2024 23:58
Copy link

codecov bot commented Nov 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.71%. Comparing base (cfd197a) to head (0d80c59).

Additional details and impacted files
@@             Coverage Diff             @@
##           staging     #470      +/-   ##
===========================================
- Coverage    99.92%   98.71%   -1.22%     
===========================================
  Files          203      203              
  Lines         2714     2714              
===========================================
- Hits          2712     2679      -33     
- Misses           2       35      +33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant